Merged
Conversation
* use default return_dict in taskmodels and remove hidden state context manager in models. * return hidden states in output of model wrapper * update to transformers 4.3.3 * black
…ments (#1268) * Use jiant transformers model wrapper instead of if-else. Use taskmodel and head factory instead of if-else. * switch to ModelArchitectures enum instead of strings
* add flat_strip test * add list to test cases flat_strip
* moves remaining if-else statments to jiant model or replaces with model agnostic method * switch from jiant_transformers_model to encoder * fix bug in flat_strip()
* move model specific tokenization logic to JiantTransformerModels * implement abstract methods for JiantTransformerModels
* Add DeBERTa with sanity test * fix tasks circular import * [WIP] add deberta tests * Revert "fix tasks circular import" This reverts commit f924640. * deberta tests passing with transformers 6472d8 * switch to deberta-v2 * black * flake8 * fix get_mlm_weights_dict() for deberta-v2 * update to transformers 4.5.0 * mark deberta test_export as slow * Update test_tokenization_normalization.py * add guide to add a model
jeswan
force-pushed
the
js/feature/easy_add_model
branch
from
04facd0 to
78647a9
Compare
jeswan
force-pushed
the
js/feature/easy_add_model
branch
from
78647a9 to
6a4da4f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1309 +/- ##
==========================================
+ Coverage 48.46% 49.77% +1.30%
==========================================
Files 163 162 -1
Lines 11220 11210 -10
==========================================
+ Hits 5438 5580 +142
+ Misses 5782 5630 -152
Continue to review full report at Codecov.
|
zphang
reviewed
Apr 28, 2021
jeswan
force-pushed
the
js/feature/easy_add_model
branch
from
e406685 to
c06267e
Compare
zphang
approved these changes
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges a major refactor feature branch making it easy for users to add a Hugging Face Transformers model. This PR adds documentation for adding a model in
guides/models/adding_models.md.This PR closes #1310, #1236, #1306, and #1191